Skip to content

Commit 9688a1c

Browse files
authored
Merge pull request #305 from krassowski/fix/negation_in_test_paths
Fix tests/mypy error for "not WIN" condition
2 parents 913689d + a86e362 commit 9688a1c

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

py_src/jupyter_lsp/tests/test_paths.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ def test_normalize_posix_path_home_subdir(
3232
assert normalized_uri(root_dir) == expected_root_uri
3333

3434

35-
@pytest.mark.skipif(~WIN, reason="can't test Windows paths on POSIX")
35+
@pytest.mark.skipif(not WIN, reason="can't test Windows paths on POSIX")
3636
@pytest.mark.parametrize(
3737
"root_dir, expected_root_uri",
3838
[
3939
["c:\\Users\\user1", "file:///c:/Users/user1"],
4040
["C:\\Users\\user1", "file:///c:/Users/user1"],
41-
["//VBOXSVR/shared-folder", "file://vboxsvr/shared-folder"],
41+
["//VBOXSVR/shared-folder", "file://vboxsvr/shared-folder/"],
4242
],
4343
)
4444
def test_normalize_windows_path_case(root_dir, expected_root_uri): # pragma: no cover
@@ -58,12 +58,13 @@ def test_file_uri_to_path_posix(file_uri, expected_posix_path): # pragma: no co
5858
assert file_uri_to_path(file_uri) == expected_posix_path
5959

6060

61-
@pytest.mark.skipif(~WIN, reason="can't test Windows paths on POSIX")
61+
@pytest.mark.skipif(not WIN, reason="can't test Windows paths on POSIX")
6262
@pytest.mark.parametrize(
6363
"file_uri, expected_windows_path",
6464
[
65-
["file:///C:/Windows/System32/Drivers/etc", r"C:\Windows\System32\Drivers\etc"],
66-
["file:///C:/some%20dir/some%20file.txt", r"C:\some dir\some file.txt"],
65+
# https://github.com/krassowski/jupyterlab-lsp/pull/305#issuecomment-665996145
66+
["file:///C:/Windows/System32/Drivers/etc", "C:/Windows/System32/Drivers/etc"],
67+
["file:///C:/some%20dir/some%20file.txt", "C:/some dir/some file.txt"],
6768
],
6869
)
6970
def test_file_uri_to_path_windows(file_uri, expected_windows_path): # pragma: no cover

0 commit comments

Comments
 (0)