Skip to content

Fix usage of conda-incubator/setup-miniconda #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Fix usage of conda-incubator/setup-miniconda #1112

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e6779b
Drop miniforge-variant
jtpio Jan 8, 2025
377ac34
try mamba-version
jtpio Jan 8, 2025
ac61bf0
try
jtpio Jan 8, 2025
99910b9
cleanup
jtpio Jan 8, 2025
a04ec1b
fix
jtpio Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions .github/workflows/job.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ jobs:
uses: conda-incubator/setup-miniconda@v3
with:
environment-file: requirements/github-actions.yml
miniforge-variant: Mambaforge
use-mamba: true
mamba-version: "*"
channels: conda-forge,nodefaults
channel-priority: true

- name: Install linting dependencies
run: mamba env update -n test --file requirements/lint.yml
Expand Down Expand Up @@ -113,10 +114,6 @@ jobs:
- name: Check distributions
run: python scripts/distcheck.py

- name: Rename uncached conda packages
shell: bash
run: mv "${CONDA_PKGS_DIR}" "${CONDA_PKGS_DIR}_do_not_cache"

build:
name: build
runs-on: ${{ matrix.os }}-latest
Expand All @@ -141,8 +138,9 @@ jobs:
- name: Set up Python and mamba
uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
use-mamba: true
mamba-version: "*"
channels: conda-forge,nodefaults
channel-priority: true

- name: Install minimal build deps
run: mamba install -n test -c conda-forge setuptools wheel 'jupyterlab${{ matrix.lab }}' 'nodejs${{ matrix.nodejs }}'
Expand Down Expand Up @@ -201,10 +199,6 @@ jobs:
name: jupyterlab-lsp dist ${{ github.run_number }}
path: ./dist

- name: Rename uncached conda packages
shell: bash
run: mv "${CONDA_PKGS_DIR}" "${CONDA_PKGS_DIR}_do_not_cache"

acceptance:
runs-on: ${{ matrix.os }}-latest
name: atest ${{ matrix.os }} py${{ matrix.python }} r${{ matrix.r }}
Expand Down Expand Up @@ -245,8 +239,9 @@ jobs:
with:
python-version: ${{ matrix.python }}
environment-file: requirements/github-actions.yml
miniforge-variant: Mambaforge
use-mamba: true
mamba-version: "*"
channels: conda-forge,nodefaults
channel-priority: true

- name: List all packages
run: conda list
Expand Down Expand Up @@ -333,10 +328,6 @@ jobs:
path: ./build/reports
if: always()

- name: Rename uncached conda packages
Copy link
Member Author

@jtpio jtpio Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was needed but it was failing. Also I would expect something like this to be handled by the conda-incubator/setup-miniconda action directly.

Copy link
Member

@krassowski krassowski Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was added in #882, more specifically in a4fb737

shell: bash
run: mv "${CONDA_PKGS_DIR}" "${CONDA_PKGS_DIR}_do_not_cache"

smoke:
name: smoke ${{ matrix.os }} py${{ matrix.python }}
runs-on: ${{ matrix.os }}-latest
Expand Down
Loading