Skip to content

Support JupyterLab 2.2 #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 11, 2020
Merged

Support JupyterLab 2.2 #301

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8290f3f
Integrate ICompletionItems
edzkite Apr 4, 2020
dddad10
Update ICompletionItems calling pattern
edzkite Apr 15, 2020
8c9ca6f
Merge branch 'completion-items' of ssh://github.com/kiteco/jupyterlab…
krassowski Jul 28, 2020
00216c4
Attempt to support JupyterLab 2.2
krassowski Jul 29, 2020
ec92128
Prettier completion.ts
krassowski Jul 29, 2020
e077218
Fix the versions integrity
krassowski Jul 29, 2020
bf52857
Fix "Module not found: Error: Can't resolve 'net'"
krassowski Jul 29, 2020
444e337
Actually use ICompletionItemsConnector :)
krassowski Jul 29, 2020
811d994
Try to restore prefixing
krassowski Jul 29, 2020
c6a0ac7
Fix loose ends in completer and its tests
krassowski Jul 29, 2020
b6fff6c
Lint robot completion tests
krassowski Jul 30, 2020
15726b5
Merge branch 'master' into kiteco-completion-items
krassowski Aug 6, 2020
4cad202
Add changelog entry for JupyterLab 2.2 support
krassowski Aug 6, 2020
a1940e4
Lint changelog
krassowski Aug 6, 2020
d2fe5bd
wait for completions to be visible before hover
bollwyvl Aug 10, 2020
cb5ad3e
use conda from defaults
bollwyvl Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/steps.conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
parameters:
name: Linux
packages: ''
install_cmd: conda install -yn base -c conda-forge conda python-libarchive-c
install_cmd: conda install -yn base conda
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is an attempt to tackle the archspec issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the thinking is get something as vanilla as possible, especially for windows, while we get this sorted. who knows what state it's in when they cook the docker images? We could also pin harder, e.g. 4.8 or something.

if we want to start getting far off vanilla, we could investigate installing mamba in this step instead of upgrading conda... no doubt it could shave off some minutes, at the price of sometimes giving different solves. definitely a separate PR, though!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also need to investigate caching (or packaging) the tectonic stuff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just thinking about mamba while reading this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open an issue...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/krassowski/jupyterlab-lsp/issues/311


steps:
- ${{ if eq(parameters.name, 'Linux') }}:
Expand Down