Skip to content

investigate escaping jumping to definition (and other features) with spaces #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 27, 2020
Merged

investigate escaping jumping to definition (and other features) with spaces #406

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0a56f16
try with bad spaces
bollwyvl Nov 10, 2020
24da4fb
linting
bollwyvl Nov 10, 2020
82b48d5
[atest] overhaul globals, jupyter config
bollwyvl Nov 12, 2020
e99ffd8
get pedantic on encodings: only utf-8 in this repo, users???
bollwyvl Nov 12, 2020
0e32480
[atest] fix virtualdoc dir variable
bollwyvl Nov 12, 2020
fef0e2f
try finding diagnostics that _contain_ canary (vs start with)
bollwyvl Nov 12, 2020
c0c153c
Merge remote-tracking branch 'upstream/master' into fix-gh-403-spaces
bollwyvl Nov 13, 2020
bb39801
hopefully demonstrate reproducible jump fail with spaces and umlaut path
bollwyvl Nov 16, 2020
86f5abe
rework handling of uri to contents path in jump
bollwyvl Nov 16, 2020
89102dd
rename jump destination from uri to contents_path throughout
bollwyvl Nov 16, 2020
2e43577
linting
bollwyvl Nov 16, 2020
d43b547
add some docs, remove some logging use of decodeURI
bollwyvl Nov 19, 2020
49e0954
update changelog
bollwyvl Nov 19, 2020
3f1ffbb
Update CHANGELOG.md
krassowski Nov 20, 2020
c82eb1b
Update CHANGELOG.md
krassowski Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/atest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
# from before https://github.com/bash-lsp/bash-language-server/pull/269
os.environ["HIGHLIGHT_PARSING_ERRORS"] = "true"

# https://github.com/krassowski/jupyterlab-lsp/issues/403
GH_403_BAD_PATH = os.environ.get("GH_403_BAD_PATH", " späces")

def get_stem(attempt, extra_args):
stem = "_".join([OS, PY, str(attempt)]).replace(".", "_").lower()
Expand All @@ -51,6 +53,7 @@ def get_stem(attempt, extra_args):
def atest(attempt, extra_args):
"""perform a single attempt of the acceptance tests"""

# TODO: investigate whether this is still required vs geckodriver 0.28
if "FIREFOX_BINARY" not in os.environ:
os.environ["FIREFOX_BINARY"] = shutil.which("firefox")

Expand Down Expand Up @@ -80,7 +83,7 @@ def atest(attempt, extra_args):
if previous.exists():
extra_args += ["--rerunfailed", str(previous)]

out_dir = OUT / stem
out_dir = OUT / (stem + GH_403_BAD_PATH)
Copy link
Member

@krassowski krassowski Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the path addition should not be pushed further down to the actual robot tests. I think that we already have one notebook with space in the name, probably just not the one testing jump functions. Though having this as a top dir would be convenient indeed.

Copy link
Collaborator Author

@bollwyvl bollwyvl Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! I was kind of tired.

Moved it (and a number of other paths) down into Variables.robot... they can be overridden with:

python -m scripts.atest --variable "NOTEBOOK DIR NAME:🐶 🐶 🐶"

would yield:

atest/output/linux_37_1/home/🐶 🐶 🐶/


args = [
"--name",
Expand Down