Skip to content

Update spec version in docs #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Update spec version in docs #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e80806d
Update spec version in docs
bollwyvl Nov 12, 2020
99e9170
backport minor atest fix from #406
bollwyvl Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions atest/07_Configuration.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ LaTeX
*** Keywords ***
Settings Should Change Editor Diagnostics
[Arguments] ${language} ${file} ${server} ${settings} ${before} ${after} ${save command}=${EMPTY} ${needs reload}=${False}
${before diagnostic} = Set Variable ${CSS DIAGNOSTIC}\[title^="${before}"]
${after diagnostic} = Set Variable ${CSS DIAGNOSTIC}\[title^="${after}"]
${before diagnostic} = Set Variable ${CSS DIAGNOSTIC}\[title*="${before}"]
${after diagnostic} = Set Variable ${CSS DIAGNOSTIC}\[title*="${after}"]
${tab} = Set Variable ${JLAB XP DOCK TAB}\[contains(., '${file}')]
${close icon} = Set Variable *[contains(@class, 'm-TabBar-tabCloseIcon')]
${save command} = Set Variable If "${save command}" ${save command} Save ${language} File
Expand Down
8 changes: 4 additions & 4 deletions docs/Configuring.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"- `argv`, a list of shell tokens to launch the server in `stdio` mode (as\n",
" opposed to `tcp`),\n",
"- the `languages` which the server will respond to, and\n",
"- the schema `version` of the spec (currently only `1`)\n",
"- the schema `version` of the spec (currently `2`)\n",
"\n",
"```python\n",
"# ./jupyter_notebook_config.json ---------- unique! -----------\n",
Expand All @@ -73,7 +73,7 @@
" \"LanguageServerManager\": {\n",
" \"language_servers\": {\n",
" \"a-language-server-implementation\": {\n",
" \"version\": 1,\n",
" \"version\": 2,\n",
" \"argv\": [\"/absolute/path/to/a-language-server\", \"--stdio\"],\n",
" \"languages\": [\"a-language\"]\n",
" }\n",
Expand Down Expand Up @@ -106,13 +106,13 @@
" # if installed as a binary\n",
" \"argv\": [shutil.which(\"a-language-server\")],\n",
" \"languages\": [\"a-language\"],\n",
" \"version\": 1\n",
" \"version\": 2\n",
" },\n",
" \"another-language-implementation\": {\n",
" # if run like a script\n",
" \"argv\": [shutil.which(\"another-language-interpreter\"), \"another-language-server\"],\n",
" \"languages\": [\"another-language\"],\n",
" \"version\": 1\n",
" \"version\": 2\n",
" }\n",
"}\n",
"```"
Expand Down