Workaround file URI matching issue for now #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsyouness
approved these changes
May 17, 2021
Contributor
bsyouness
left a comment
bsyouness
left a comment
There was a problem hiding this comment.
Looks good, thank you and sorry I couldn't help more! I would maybe add a comment for where the mac stuff is happening and another comment to remove this when the fix rolls out upstream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
See #595. This is not the ultimate nor preferred solution, but let's have CI (and extension) working for now. Hopefully this can be rolled back before the next release (conditional on url-parse getting a new release with merged fix and JupyterLab 3.0.16 picking up the update).
Code changes
User-facing changes
Backwards-incompatible changes
Chores