Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented May 19, 2021

References

Quick heads up that JupyterLab Classic has been renamed to RetroLab: https://github.com/jtpio/retrolab/issues/118

Opening the PR early as a draft to make sure it still works as expected with the lsp extension.

Code changes

  • Update the @jupyerlab-classic to @retrolab
  • IClassicShell -> IRetroShell

User-facing changes

None

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@jtpio jtpio marked this pull request as ready for review May 25, 2021 11:37
@jtpio
Copy link
Member Author

jtpio commented May 28, 2021

Updated to the latest retrolab package.

Should be good to go now.

@krassowski
Copy link
Member

Thanks!

@krassowski krassowski merged commit 8f7669e into jupyter-lsp:master May 28, 2021
@jtpio jtpio deleted the retrolab branch May 28, 2021 11:45
@krassowski krassowski added this to the 3.7 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants