Skip to content

Conversation

@krassowski
Copy link
Member

@krassowski krassowski commented Dec 31, 2021

References

Fixes #1. Closes #18 as outdated.

Code changes

  • fix some incorrect types for Hover and references client requests
  • add target selections if multiple choices exist for jump target
  • allow jumping to references
  • remove unused "Highlight references" and "Highlight type references" commands and context menu entries which were doing nothing
  • deprecate internals manual getters and protocol invokations in ws connector (mostly for myself so I see their uses and can remove them easily)

TODO robot tests for:

  • test jumping to node_modules/@jupyterlab/ to make sure decoding (of @) is handled correctly
  • test jump target selection
  • test references
  • update README

User-facing changes

  • Alt + 🖱️ click will now jump to references if the initial jump to definition indicates that user's clicked on the (only) definition, or if no definition was found
  • jumping to sources in packages with namespaces (@) will now work correctly
  • when multiple jump targets are present, a selection dialog will show up

jump-selector-references

Backwards-incompatible changes

  • Jump to definition feature API got restricted and refactored

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski added this to the 4.0 milestone Dec 31, 2021
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jupyter-lsp/jupyterlab-lsp/jump-to-references

@krassowski krassowski mentioned this pull request Jan 1, 2022
13 tasks
@krassowski krassowski merged commit 84121b4 into master Jan 1, 2022
@krassowski krassowski deleted the jump-to-references branch January 1, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement "Highlight all" action in notebooks Allow multiple choices in "go-to" action

2 participants