Skip to content

Better handling of an empty container status in confirm_remote_startup #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Better handling of an empty container status in confirm_remote_startup #1370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8adba15
Added better handling for empty status of kernel container during ker…
OrenZ1 Feb 29, 2024
b255c43
Modified grammer of error message
OrenZ1 Feb 29, 2024
c9da1f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions enterprise_gateway/services/processproxies/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,15 @@ async def confirm_remote_startup(self) -> None:
"""Confirms the container has started and returned necessary connection information."""
self.log.debug("Trying to confirm kernel container startup status")
self.start_time = RemoteProcessProxy.get_current_time()
i = 0
i = 1
container_status = self.get_container_status(i)
while not container_status:
i += 1
self.detect_launch_failure()
await self.handle_timeout()

container_status = self.get_container_status(i)

ready_to_connect = False # we're ready to connect when we have a connection file to use
while not ready_to_connect:
i += 1
Expand All @@ -211,7 +219,11 @@ async def confirm_remote_startup(self) -> None:
)
self.pgid = 0
else:
self.detect_launch_failure()
self.log_and_raise(
http_status_code=500,
reason="Error starting kernel container; status was not available. "
"Perhaps the kernel pod died unexpectedly",
)

def get_process_info(self) -> dict[str, Any]:
"""Captures the base information necessary for kernel persistence relative to containers."""
Expand Down