Skip to content

Conversation

lresende
Copy link
Member

No description provided.

@lresende lresende requested a review from Copilot June 23, 2025 01:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for Python 3.8 to fix build issues by updating version requirements across configuration files and documentation.

  • Updated classifiers and the Python requirement in pyproject.toml
  • Updated Docker README and environment.yml to reflect Python 3.9
  • Updated workflow configurations in .github/workflows/build.yml to remove Python 3.8 support

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pyproject.toml Removed Python 3.8 classifier and updated requires-python to >=3.9
etc/docker/demo-base/README.md Updated description to indicate usage of Python 3.9
docs/environment.yml Changed the Python dependency version from 3.8 to 3.9
.github/workflows/build.yml Removed Python 3.8 from the test matrix and updated configuration

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lresende. This has my approval whenever you are done.

@lresende
Copy link
Member Author

Thank you @kevin-bates , I believe there are two main issues here:

  • zmq build related issues
  • default python 3.12 from jupyterlab maintainer tools not allowing to downgrade python

Will find some time and continue on this until we get a green build

@lresende lresende force-pushed the remove-py-38 branch 2 times, most recently from 67e736f to 9943114 Compare June 24, 2025 06:29
@lresende lresende force-pushed the remove-py-38 branch 2 times, most recently from 0dc0b1a to 8b0e0a0 Compare June 29, 2025 01:57
@lresende lresende added the waiting for author Waiting for information from item's author label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting for information from item's author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants