Enforce path imports for mui icons, Migrate to newer eslint (v8)#572
Merged
andrii-i merged 4 commits intojupyter-server:mainfrom Feb 13, 2025
Merged
Enforce path imports for mui icons, Migrate to newer eslint (v8)#572andrii-i merged 4 commits intojupyter-server:mainfrom
andrii-i merged 4 commits intojupyter-server:mainfrom
Conversation
andrii-i
reviewed
Feb 11, 2025
Collaborator
There was a problem hiding this comment.
Thank you for working on this @astitv-sh.
Summarizing our discussion on next steps:
- To address three
@typescript-eslint/no-unused-varswarnings from the "Build" CI run, please omit catch parameter in all cases by changing catch statements with catch parameters to catch statements without catch parameters:
} catch {- To address the lint error, please update the lint rule name in the disable comment
- I will fix E2E failures
Collaborator
|
@astitv-sh thank you for the updates. Please investigate the CI failure by looking at CI error text and identifying the root cause, then potentially fixing it if test failure is not related to the logic being tested. |
Collaborator
|
1dbc0d6 sets a no-op filter if extraction filter is supported. Extraction filter is supported in Python 3.12+ and throws warnings if not present. It will become required in 3.14+ https://docs.python.org/3.14/library/tarfile.html#supporting-older-python-versions |
andrii-i
approved these changes
Feb 13, 2025
Collaborator
There was a problem hiding this comment.
Looks good, thank you @astitv-sh. I tested changes with Python 3.11 and Python 3.12.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Changes to resolve #571. Follows the changes made in similar PR jupyterlab/jupyter-ai#1225
Code changes
User-facing changes
N/A
Testing
Before:
After:
Backwards-incompatible changes
N/A