Closed
Conversation
andrii-i
force-pushed
the
async-upload
branch
2 times, most recently
from
5427d4d to
f43d576
Compare
for more information, see https://pre-commit.ci
Collaborator
Author
|
Moving upload logic to executors instead of a schedulers attempted in this PR to make files upload async without breaking the API would make upload happen on a different stage by a different component breaking the API. And with API breakage rewriting key API methods to be async and utilizing async/await would be enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #573
Code changes
User-facing changes
Backwards-incompatible changes