Add extensible DatabaseManager class enabling custom database backends support#590
Draft
andrii-i wants to merge 7 commits intojupyter-server:mainfrom
Draft
Add extensible DatabaseManager class enabling custom database backends support#590andrii-i wants to merge 7 commits intojupyter-server:mainfrom
DatabaseManager class enabling custom database backends support#590andrii-i wants to merge 7 commits intojupyter-server:mainfrom
Conversation
andrii-i
force-pushed
the
database_manager
branch
from
0e4a965 to
e7f8d38
Compare
andrii-i
force-pushed
the
database_manager
branch
2 times, most recently
from
5576879 to
ceec337
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Problem
Currently, while users can customize the database URL via
db_urltraitlet, theDatabaseManager.create_sessionandDatabaseManager.create_tablesfunctions inorm.pyare tightly coupled to SQLAlchemy, which essentially means that while users can specify different database URLs they must be SQLAlchemy-compatible which is limiting.Proposed solution / Code changes
Introduce extensible
DatabaseManagerclass that can be configured via traitlets.User-facing changes
None
Backwards-incompatible changes
None