Skip to content
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,3 @@ dmypy.json

# macOS
.DS_Store

# Copied changelog
docs/source/**/changelog.md
24 changes: 24 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,27 @@ To run the Python tests, use:
```bash
pytest
```

## Documentation

Contributions can also take the form of fixes and improvements to the documentation.

To build the docs, run:

```bash
hatch run docs:build
```

To serve the docs:

```bash
hatch run docs:serve
```

It is also possible to automatically watch the docs with the following command:

```bash
hatch run docs:watch
```

Then open http://localhost:8000 in your browser to view the documentation.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ See the [adoption guides](https://jupyter-releaser.readthedocs.io/en/latest/how_

GitHub actions scripts are available to draft a changelog, draft a release, publish a release, and check a release.

See the [action details documentation](https://jupyter-releaser.readthedocs.io/en/latest/background/theory.html#action-details) for more information.
See the [action details documentation](https://jupyter-releaser.readthedocs.io/en/latest/reference/theory.html#action-details) for more information.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check-links failure is expected, and should resolve itself after merging:

image


The actions can be run on a [fork](https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo_from_releaser.html) of `jupyter_releaser` and target multiple
repositories, or run as workflows on the [source repositories](https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo_from_repo.html), using
Expand Down
20 changes: 0 additions & 20 deletions docs/Makefile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to remove makefiles or is it just that there is a different way these are no longer needed? I just wonder how much of a burden keeping them is, it feels pretty standard to be able to use make for sphinx compliation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the motivation here was to to keep it simple and have the hatch scripts be the recommended way for building the docs. And ReadTheDocs can build the docs without the Makefiles.

Also Makefiles tend to look complicated (although it could be more of a personal opinion).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if they are used by maintainers / contributors of this repo then we could keep them yes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Makefiles tend to look complicated (although it could be more of a personal opinion).

True

But if they are used by maintainers / contributors of this repo then we could keep them yes.

I would probably switch to hatch commands, not sure about other contributors.

This file was deleted.

35 changes: 0 additions & 35 deletions docs/make.bat

This file was deleted.

9 changes: 0 additions & 9 deletions docs/source/background/index.rst

This file was deleted.

5 changes: 1 addition & 4 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,13 @@
# sys.path.insert(0, os.path.abspath('.'))
import importlib.metadata
import os.path as osp
import shutil

HERE = osp.abspath(osp.dirname(__file__))

# -- Project information -----------------------------------------------------

project = "Jupyter Releaser"
copyright = "2021, Project Jupyter"
copyright = "2024, Project Jupyter"
author = "Project Jupyter"

# The full version, including alpha/beta/rc tags.
Expand Down Expand Up @@ -90,6 +89,4 @@


def setup(app):
dest = osp.join(HERE, "reference", "changelog.md")
shutil.copy(osp.join(HERE, "..", "..", "CHANGELOG.md"), dest)
app.add_css_file("custom.css")
12 changes: 12 additions & 0 deletions docs/source/get_started/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Getting Started

Tutorials. A hands-on introduction to Jupyter Releaser for maintainers.

```{toctree}
:caption: 'Contents:'
:maxdepth: 1

making_release_from_repo
making_release_from_releaser
generate_changelog
```
11 changes: 0 additions & 11 deletions docs/source/get_started/index.rst

This file was deleted.

13 changes: 13 additions & 0 deletions docs/source/how_to_guides/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# How-to Guides

Step-by-step guides. Covers key tasks and operations and common problems

```{toctree}
:caption: 'Contents:'
:maxdepth: 1

convert_repo_from_releaser
convert_repo_from_repo
write_config
maintain_fork
```
12 changes: 0 additions & 12 deletions docs/source/how_to_guides/index.rst

This file was deleted.

24 changes: 24 additions & 0 deletions docs/source/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Jupyter Releaser

**Jupyter Releaser** contains a set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.

```{toctree}
:maxdepth: 2

get_started/index
how_to_guides/index
reference/index
reference/faq
```

```{toctree}
:maxdepth: 1

reference/changelog
```

# Indices and tables

- {ref}`genindex`
- {ref}`modindex`
- {ref}`search`
19 changes: 0 additions & 19 deletions docs/source/index.rst

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,30 +1,39 @@
API Docs
========
# API Docs

Library Functions
-----------------
## Library Functions

```{eval-rst}
.. automodule:: jupyter_releaser.lib
:members:
```

## Python Utility Functions

Python Utility Functions
------------------------
```{eval-rst}
.. automodule:: jupyter_releaser.python
:members:

```

## NPM Utility Functions

NPM Utility Functions
------------------------
```{eval-rst}
.. automodule:: jupyter_releaser.npm
:members:

```

Changelog Utility Functions
---------------------------
## Changelog Utility Functions

```{eval-rst}
.. automodule:: jupyter_releaser.changelog
:members:

```

## Global Utility Functions

Global Utility Functions
------------------------
```{eval-rst}
.. automodule:: jupyter_releaser.util
:members:
```
2 changes: 2 additions & 0 deletions docs/source/reference/changelog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
```{include} ../../../CHANGELOG.md
```
15 changes: 15 additions & 0 deletions docs/source/reference/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Reference

Technical reference. Covers tools, components, commands, and resources.

```{toctree}
:maxdepth: 1
:caption: Contents:

releaser_cli
api_docs
configuration
theory
changelog
faq
```
13 changes: 0 additions & 13 deletions docs/source/reference/index.rst

This file was deleted.

6 changes: 6 additions & 0 deletions docs/source/reference/releaser_cli.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Releaser CLI

```{click} jupyter_releaser.cli:main
:prog: jupyter-releaser
:nested: full
```
6 changes: 0 additions & 6 deletions docs/source/reference/releaser_cli.rst

This file was deleted.

File renamed without changes.
5 changes: 4 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ content-type = "text/markdown"
[project.optional-dependencies]
docs = [
"sphinx",
"sphinx-autobuild",
"sphinx-copybutton",
"pip",
"myst-parser",
Expand Down Expand Up @@ -73,7 +74,9 @@ validate-bump = false
[tool.hatch.envs.docs]
features = ["docs"]
[tool.hatch.envs.docs.scripts]
build = "make -C docs html SPHINXOPTS='-W'"
build = "sphinx-build -W -b html docs/source docs/build/html"
serve = "python -m http.server --directory docs/build/html"
watch = "sphinx-autobuild -W -b html docs/source docs/build/html --host 0.0.0.0"

[tool.hatch.envs.test]
features = ["test"]
Expand Down
Loading