Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Oct 19, 2024

Fixes #584

image

@jtpio jtpio added the documentation Improvements or additions to documentation label Oct 19, 2024
@jtpio jtpio marked this pull request as ready for review October 19, 2024 08:31
Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!


The releaser may fail to publish a package to the `npm` in the following cases:

- `npmjs.com` is down, or `npm` is encountering issues publishing new packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking whether to add a point about some other once we saw in JupyterLab:

but I am not sure how often these pop up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong URLs break publishing to npm with provenance:

This one should normally be caught by check-release? #539

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should normally be caught by check-release?

Yes, that's what I was thinking

@krassowski
Copy link
Collaborator

@jtpio I will let you merge because I see that this might introduce conflicts with #587

@jtpio
Copy link
Member Author

jtpio commented Oct 21, 2024

Sounds good. Maybe we can then try to merge #587 first, since it touches more files?

@jtpio jtpio enabled auto-merge (squash) October 21, 2024 15:39
@jtpio jtpio merged commit 16974dd into jupyter-server:main Oct 21, 2024
17 checks passed
@jtpio jtpio deleted the improve-faq branch October 21, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more items to the FAQ

2 participants