Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Oct 14, 2025

Fixes #612

@jtpio jtpio added the documentation Improvements or additions to documentation label Oct 14, 2025
@jtpio jtpio closed this Oct 15, 2025
@jtpio jtpio reopened this Oct 15, 2025
@jtpio jtpio force-pushed the npm-trusted-publishers branch from 951e3b4 to 797c1f5 Compare December 1, 2025 16:18
@jtpio jtpio marked this pull request as ready for review December 1, 2025 16:59
Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio for working on this.

It looks good to me (I haven't tried the whole workflow, though).

@brichet
Copy link
Contributor

brichet commented Dec 2, 2025

Maybe not for this PR, but I wonder if we could fix indentation in doc, I find it confusing (it is the same for PyPI):

image

@jtpio
Copy link
Member Author

jtpio commented Dec 2, 2025

Maybe not for this PR, but I wonder if we could fix indentation in doc, I find it confusing (it is the same for PyPI):

Right, probably the docs should be revamped as they look a bit complicated currently. But now with the GitHub app and the PyPI / npm trusted publishers it should be easier to set up, so the default guide could be much simpler.

@krassowski krassowski merged commit 28d08b1 into jupyter-server:main Dec 2, 2025
19 checks passed
@jtpio jtpio deleted the npm-trusted-publishers branch December 2, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support npm trusted publishers

3 participants