Skip to content

Check file permissions before making tmp file #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2025
Merged

Check file permissions before making tmp file #1513

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65e5969
check file permissions before making tmp file
RRosio Apr 15, 2025
d8e0d13
fix added logs
RRosio Apr 20, 2025
9bedfb5
Update jupyter_server/services/contents/fileio.py
RRosio Apr 24, 2025
8a76a48
Update jupyter_server/services/contents/fileio.py
RRosio Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions jupyter_server/services/contents/fileio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ def copy2_safe(src, dst, log=None):

like shutil.copy2, but log errors in copystat instead of raising
"""
# if src file is not writable, avoid creating a back-up
if not os.access(src, os.W_OK):
if log:
log.debug("Source file, %s, is not writeable", src, exc_info=True)
raise PermissionError(errno.EACCES, f"File is not writable: {src}")

shutil.copyfile(src, dst)
try:
shutil.copystat(src, dst)
Expand All @@ -52,6 +58,11 @@ async def async_copy2_safe(src, dst, log=None):

like shutil.copy2, but log errors in copystat instead of raising
"""
if not os.access(src, os.W_OK):
if log:
log.debug("Source file, %s, is not writeable", src, exc_info=True)
raise PermissionError(errno.EACCES, f"File is not writable: {src}")

await run_sync(shutil.copyfile, src, dst)
try:
await run_sync(shutil.copystat, src, dst)
Expand Down
Loading