Skip to content

Turn ExtensionPoint class into a LoggingConfigurable to enable logging #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Turn ExtensionPoint class into a LoggingConfigurable to enable logging #1522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jupyter_server/extension/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
from itertools import starmap

from tornado.gen import multi
from traitlets import Any, Bool, Dict, HasTraits, Instance, List, Unicode, default, observe
from traitlets import Any, Bool, Dict, Instance, List, Unicode, default, observe
from traitlets import validate as validate_trait
from traitlets.config import LoggingConfigurable

from .config import ExtensionConfigManager
from .utils import ExtensionMetadataError, ExtensionModuleNotFound, get_loader, get_metadata


class ExtensionPoint(HasTraits):
class ExtensionPoint(LoggingConfigurable):
"""A simple API for connecting to a Jupyter Server extension
point defined by metadata and importable from a Python package.
"""
Expand Down Expand Up @@ -227,7 +227,7 @@ def _load_metadata(self):
raise ExtensionModuleNotFound(msg) from None
# Create extension point interfaces for each extension path.
for m in self.metadata:
point = ExtensionPoint(metadata=m)
point = ExtensionPoint(metadata=m, parent=self)
self.extension_points[point.name] = point
return name

Expand Down
Loading