Allow specifying extra params to scrub from logs #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
force-pushed
the
configurable-scrub-param-keys
branch
from
996ec7d to
6732048
Compare
|
CI is all passing ✅ This should now be ready for review! |
vidartf
reviewed
Jul 10, 2025
vidartf
reviewed
Aug 6, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1536
c.ServerApp.extra_log_scrub_param_keysCurrently the extra param keys do not replace the default set of keys, to avoid altering the current behavior by mistake. Instead they are added to the current set of param keys.