Skip to content

Fix nbconvert handler #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Fix nbconvert handler #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion jupyter_server/services/nbconvert/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import json
import asyncio

from anyio.to_thread import run_sync
from tornado import web

from ...base.handlers import APIHandler


LOCK = asyncio.Lock()

class NbconvertRootHandler(APIHandler):

@web.authenticated
Expand All @@ -20,7 +23,8 @@ async def get(self):
exporters = await run_sync(base.get_export_names)
for exporter_name in exporters:
try:
exporter_class = await run_sync(base.get_exporter, exporter_name)
async with LOCK:
exporter_class = await run_sync(base.get_exporter, exporter_name)
except ValueError:
# I think the only way this will happen is if the entrypoint
# is uninstalled while this method is running
Expand Down