Skip to content

Fix stream output #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix stream output #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd6987c
Fix stream output
davidbrochart Dec 2, 2024
919625f
Fix tests
davidbrochart Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion jupyter_ydoc/ynotebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,12 @@ def create_ycell(self, value: Dict[str, Any]) -> Map:
outputs = cell.get("outputs", [])
for idx, output in enumerate(outputs):
if output.get("output_type") == "stream":
output["text"] = Array(output.get("text", []))
text = output.get("text", "")
if isinstance(text, str):
ytext = Text(text)
else:
ytext = Text("".join(text))
output["text"] = ytext
outputs[idx] = Map(output)
cell["outputs"] = Array(outputs)
cell["execution_state"] = "idle"
Expand Down
4 changes: 2 additions & 2 deletions tests/test_pycrdt_yjs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ async def test_ypy_yjs_1(yws_server, yjs_client):
ydoc, Websocket(websocket, room_name)
):
output_text = ynotebook.ycells[0]["outputs"][0]["text"]
assert output_text.to_py() == ["Hello,"]
assert output_text.to_py() == "Hello,"
event = Event()

def callback(_event):
Expand All @@ -101,7 +101,7 @@ def callback(_event):
with move_on_after(10):
await event.wait()

assert output_text.to_py() == ["Hello,", " World!"]
assert output_text.to_py() == "Hello,", " World!"


def test_plotly_renderer():
Expand Down
Loading