Skip to content

Commit 7af4b65

Browse files
committed
Update tests
Signed-off-by: Itay Dafna <[email protected]>
1 parent 9efa755 commit 7af4b65

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

tests/js/datagrid.test.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,23 +129,21 @@ describe('Test trait: data', () => {
129129
).toEqual(oldTransforms);
130130
});
131131

132-
test('HeaderRenderer updated with reference to new model', async () => {
132+
test('HeaderRenderer keeps same data model ref on data change (same model, new data)', async () => {
133133
const testData = Private.createBasicTestData();
134134
const grid = await Private.createGridWidget({
135135
data: testData.set1,
136136
modelAttributes: { selection_mode: 'cell' },
137137
});
138138
const cornerCellConfig = Private.createCellConfig('corner-header');
139139
const columnCellConfig = Private.createCellConfig('column-header');
140-
const oldColHead = grid.view.grid.cellRenderers.get(cornerCellConfig);
141-
const oldCornerHead = grid.view.grid.cellRenderers.get(columnCellConfig);
140+
const oldCornerHead = grid.view.grid.cellRenderers.get(cornerCellConfig);
141+
const oldColHead = grid.view.grid.cellRenderers.get(columnCellConfig);
142142
grid.model.set('_data', testData.set2);
143-
expect(grid.view.grid.cellRenderers.get(cornerCellConfig)).not.toBe(
143+
expect(grid.view.grid.cellRenderers.get(cornerCellConfig)).toBe(
144144
oldCornerHead,
145145
);
146-
expect(grid.view.grid.cellRenderers.get(columnCellConfig)).not.toBe(
147-
oldColHead,
148-
);
146+
expect(grid.view.grid.cellRenderers.get(columnCellConfig)).toBe(oldColHead);
149147
});
150148

151149
test('Correct index of the grid is determined from column name', async () => {

0 commit comments

Comments
 (0)