Add hide column option to context menu #496
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase your PR |
gjmooney
force-pushed
the
hide_column
branch
2 times, most recently
from
6b6a637 to
e9d9701
Compare
Signed-off-by: gjmooney <[email protected]> Signed-off-by: Greg <[email protected]>
Signed-off-by: Greg <[email protected]>
Signed-off-by: Greg <[email protected]>
Signed-off-by: Greg <[email protected]>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'Hide Column' option to column context menu.
Issues:
Hiding a second column has some issues, this is because the column index that comes from the Hit Test result on a mouse click appears to be calculated based on the displayed grid, and the transforms are applied based on column index. So if you hide the original first column, the second column becomes the 'new' first column, and when you try to hide that 'new' column 1, index 1 already has a transform applied and nothing happens.