Skip to content

Fix some DeprecationWarning #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

xoolive
Copy link
Contributor

@xoolive xoolive commented Oct 7, 2019

Following discussion #414 (comment)

There is still one DeprecationWarning to fix in traittypes.Dataset (dtype should be set in a tag() method)

@martinRenou
Copy link
Member

Concerning the Dataset trait, I wonder if you could not simply remove the dtype tag, it's set to its default value (None) anyway.

@martinRenou
Copy link
Member

Thanks a lot for the PR !!

@xoolive
Copy link
Contributor Author

xoolive commented Oct 7, 2019

I think it should be enough to remove it but in the traittypes package

@martinRenou
Copy link
Member

I think it should be enough to remove it but in the traittypes package

Well, dtype seems to be used in the traittypes package, only we set it to None because I guess we don't want to force the user to use a specific dtype. I suppose removing it from ipyleaflet is just fine.

@xoolive
Copy link
Contributor Author

xoolive commented Oct 7, 2019

Well, I can't say: maybe it's fine, but it doesn't fix the warning 😞

@martinRenou
Copy link
Member

I don't have those warnings... Which traitlets version are you using?

@xoolive
Copy link
Contributor Author

xoolive commented Oct 7, 2019

traitlets==4.3.2

But I don't get the warnings on a regular import, only when imported through an entry point:

# something along
for entry_point in pkg_resources.iter_entry_points("personal.stuff"):
    entry_point.load()

@martinRenou
Copy link
Member

I can merge this one as it is right now as it fixes some more warnings.

Thanks a lot for this PR! :)
I'll investigate concerning this Dataset thing

@martinRenou martinRenou merged commit 1853a62 into jupyter-widgets:master Oct 8, 2019
@xoolive
Copy link
Contributor Author

xoolive commented Oct 8, 2019

Thanks, about the extra warning, see jupyter-widgets/traittypes#41

@martinRenou
Copy link
Member

Good!! :) Thanks very much

@xoolive xoolive deleted the pr-fix_depwarn branch October 9, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants