weakref to enable gc + setting children with iterable + fix various tooltips #3921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Example for FloatLogSlider labeled min and max in reverse order; changed it so it is correct.
1. @lumino/messaging ^2.1 should be ^2.0.1 2. @lumino/messaging ^2.1 should be ^2.0.1 3. istanbul-instrumenter-loader is not maintaned for 6 years
…pe of iterable plus a configurable option to omit invalid items (including closed widgets) and log a warning or error.
fleming79
changed the title
added 2 commits
August 31, 2024 10:25
vijayi1
reviewed
Sep 9, 2024
|
@vijayi1 Thanks for pointing that out. Attached are files for the latest . |
|
@fleming79 , the fix works for me, thanks.
|
…get_instances to fix a Segmentation Fault that was causing test failure. Also added the static method Widget.all_widgets that returns a copy of the current widgets.
…and Widget.get_manager_state to omit invalid widgets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3893.
Commits have been tidied up.
Resolves