Skip to content

Conversation

@pcuste1
Copy link
Contributor

@pcuste1 pcuste1 commented Oct 22, 2025

What is changing?

Small bugfix to fix an error that occurs when ref == None

Why is this required?

Without this change, we attempt to access self.ref.anchor of None which throws an error. This small fix avoids that issue and manual testing shows that sidecar works appropriately with ref=None

How was this tested

The following code fails to run before this change, and after this change succeeds and opens a healthy sidecar instance as expected.

from sidecar import Sidecar

my_sidecar = Sidecar(anchor="split-right", title="test", ref=None)

Small bugfix to fix an error that occurs when `ref == None`
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrick, I'm bummed I missed this.

@martinRenou martinRenou added the bug Something isn't working label Oct 23, 2025
@martinRenou martinRenou merged commit 45c9fe6 into jupyter-widgets:master Oct 23, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants