Skip to content

JupyterLab 2 support #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2020
Merged

JupyterLab 2 support #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b78e139
Attempt fix support for JupyterLab 2
consideRatio Mar 18, 2020
a42613b
Apply suggestions to fix typescript compilation
consideRatio Mar 18, 2020
9494dd2
Security update of dependencies
consideRatio Mar 19, 2020
331533f
Adjust boilerplate tests to actual code
consideRatio Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6,628 changes: 2,850 additions & 3,778 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

39 changes: 20 additions & 19 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@jupyter-widgets/jupyterlab-sidecar",
"version": "0.4.0",
"version": "0.5.0",
"description": "A sidecar output widget for JupyterLab",
"keywords": [
"jupyter",
Expand Down Expand Up @@ -38,31 +38,32 @@
"watch:lib": "tsc"
},
"dependencies": {
"@jupyter-widgets/base": "^2.0.1",
"@jupyter-widgets/jupyterlab-manager": "^1.0.0",
"@jupyterlab/application": "^1.0.0"
"@jupyter-widgets/base": "^3.0.0",
"@jupyter-widgets/jupyterlab-manager": "^2.0.0",
"@jupyterlab/application": "^2.0.0",
"@lumino/coreutils": "^1.4.2"
},
"devDependencies": {
"@types/expect.js": "^0.3.29",
"@types/mocha": "^2.2.41",
"@types/node": "^8.0.17",
"@types/mocha": "^7.0.2",
"@types/node": "^13.9.1",
"expect.js": "^0.3.1",
"fs-extra": "^4.0.2",
"fs-extra": "^8.1.0",
"json-loader": "^0.5.7",
"karma": "^1.7.0",
"karma-chrome-launcher": "^2.2.0",
"karma-firefox-launcher": "^1.0.1",
"karma": "^4.4.1",
"karma-chrome-launcher": "^3.1.0",
"karma-firefox-launcher": "^1.3.0",
"karma-ie-launcher": "^1.0.0",
"karma-mocha": "^1.3.0",
"karma-mocha-reporter": "^2.2.3",
"karma-typescript": "^3.0.5",
"mkdirp": "^0.5.1",
"mocha": "^3.5.0",
"npm-run-all": "^4.1.1",
"rimraf": "^2.6.2",
"source-map-loader": "^0.2.1",
"ts-loader": "^2.3.2",
"typescript": "~3.5.2"
"karma-mocha-reporter": "^2.2.5",
"karma-typescript": "^5.0.0",
"mkdirp": "^1.0.3",
"mocha": "^7.1.0",
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2",
"source-map-loader": "^0.2.4",
"ts-loader": "^6.2.1",
"typescript": "^3.8.3"
},
"jupyterlab": {
"extension": "lib/plugin"
Expand Down
2 changes: 1 addition & 1 deletion src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {

import {
UUID
} from '@phosphor/coreutils';
} from '@lumino/coreutils';

import {
IJupyterWidgetRegistry
Expand Down
1 change: 1 addition & 0 deletions src/widget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class SidecarModel extends OutputModel {

initialize(attributes: any, options: any) {
super.initialize(attributes, options);
// FIXME: Argument of type 'undefined' is not assignable to parameter of type 'IMessage<MessageType>'.
this.widget_manager.display_model(undefined, this, {});
}

Expand Down
2 changes: 2 additions & 0 deletions tests/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import {
} from './utils.spec';

import {
// FIXME: Module '"../../src"' has no exported member 'ExampleModel'.
// FIXME: Module '"../../src"' has no exported member 'ExampleView'.
ExampleModel, ExampleView
} from '../../src/'

Expand Down
1 change: 1 addition & 0 deletions tests/src/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class MockComm {
on_msg(fn: Function | null) {
this._on_msg = fn;
}
// FIXME: Namespace '"REDACTED/jupyterlab-sidecar/node_modules/@jupyterlab/services/lib/kernel/messages"' has no exported member 'ICommMsg'.
_process_msg(msg: services.KernelMessage.ICommMsg) {
if (this._on_msg) {
return this._on_msg(msg);
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"compilerOptions": {
"declaration": true,
"esModuleInterop": true,
"noImplicitAny": true,
"noEmitOnError": true,
"noUnusedLocals": true,
Expand Down