Make xeus static/shared build user configurable for linking

[anutosh491]

As we now provide a shared and a static build for xeus through emscripten-forge, this can be made user configurable.

I've used the shared build for xeus by default through XEUS_LITE_USE_SHARED_XEUS

[anutosh491]

Ahh the failure is because we have this

xeus-lite/BuildWasmDockerfile

Lines 29 to 41 in eceb40c

	RUN mkdir -p /deps/xeus/build
	RUN git clone --branch 5.0.0 https://github.com/jupyter-xeus/xeus.git /deps/xeus/src
	#COPY xeus /deps/xeus/src
	RUN cd /deps/xeus/build && \
	emcmake cmake ../src \
	-DCMAKE_INSTALL_PREFIX=/install \
	-Dnlohmann_json_DIR=/install/share/cmake/nlohmann_json \
	-DXEUS_EMSCRIPTEN_WASM_BUILD=ON
	RUN cd /deps/xeus/build && \
	emmake make -j8 install

And although we merged the PR on xeus, there hasn't been a release there and hence this can't fetch it !

P.S: Was there some reason why we don't use an env but use a dockerfile for testing here ?

[SylvainCorlay]

Ahh the failure is because we have this

xeus-lite/BuildWasmDockerfile

Lines 29 to 41 in eceb40c

	RUN mkdir -p /deps/xeus/build
	RUN git clone --branch 5.0.0 https://github.com/jupyter-xeus/xeus.git /deps/xeus/src
	#COPY xeus /deps/xeus/src
	RUN cd /deps/xeus/build && \
	emcmake cmake ../src \
	-DCMAKE_INSTALL_PREFIX=/install \
	-Dnlohmann_json_DIR=/install/share/cmake/nlohmann_json \
	-DXEUS_EMSCRIPTEN_WASM_BUILD=ON
	RUN cd /deps/xeus/build && \
	emmake make -j8 install

And although we merged the PR on xeus, there hasn't been a release there and hence this can't fetch it !

P.S: Was there some reason why we don't use an env but use a dockerfile for testing here ?

Since you do --branch 5.0.0, we could test with --branch main for now.

[SylvainCorlay]

we could test with --branch main for now.

This would validate making a xeus release.

[SylvainCorlay]

The test kernel complains about libxeus.so not being there. It is not picked up by the copy_files.sh because of the .so extension...

Shouldn't libxeus' shared object have a different extension in the WebAssembly case?

[anutosh491]

The test kernel complains about libxeus.so not being there.

Hmm, Yes I think it needs to be in the same location as the test_xx.js/wasm files

[anutosh491]

Hmm still fails, not sure what I miss :
Will try again Monday

[anutosh491]

I see this error on the 3.1.73 CI

node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[LinkError: WebAssembly.instantiate(): Import #147 module="env" function="strtoull" error: imported function does not match the expected type]

Not sure where this LinkError comes from cause I am able to run the tests locally with 3.1.73 without any issues ☹️

[SylvainCorlay]

Maybe @DerThorsten knows what changes between emscripten 3.1 and 4.0 that could trigger this issue.

[anutosh491]

knows what changes between emscripten 3.1 and 4.0 that could trigger this issue.

hmm locally emscripten 3.1.73 and node 16 does the job for me !

[DerThorsten]

using #20