Switch to a shared xeus for the emscripten build #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anutosh491
commented
Jul 1, 2025
|
|
||
| set(XPYT_BUILD_STATIC OFF) | ||
| set(XPYT_BUILD_SHARED OFF) | ||
| set(XPYT_BUILD_XPYTHON_EXECUTABLE OFF) | ||
| set(XPYT_BUILD_XPYTHON_EXTENSION OFF) | ||
| set(XPYT_USE_SHARED_XEUS OFF) |
There was a problem hiding this comment.
This is enough to link with libxeus.so (ON by default)
anutosh491
commented
Jul 1, 2025
| configure_file ( | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/share/jupyter/kernels/xpython/wasm_kernel.json.in" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/share/jupyter/kernels/xpython/kernel.json" | ||
| ) |
There was a problem hiding this comment.
Fetching xeus-python from emscripten-forge, I see that we're only interested in the xpython build and not xpython-raw so we can skip configuring it for the wasm use case.
|
cc @martinRenou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicating the PR on xeus-cpp so that xeus-python can use the latest xeus & xeus-lite.
compiler-research/xeus-cpp#334