Skip to content

Enable CUDA build for ARM64 #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Enable CUDA build for ARM64 #2352

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01d29ae
add aarch64 cuda12
dictcp Nov 18, 2025
b56c069
Remove conditional check for 'cuda' variant in aarch64 image tag down…
dictcp Nov 18, 2025
f34b92c
Merge branch 'main' into cuda12-arm
mathbunnyru Nov 18, 2025
7bb1792
Merge branch 'main' into cuda12-arm
mathbunnyru Nov 20, 2025
3817d82
Make aarch64 come always right before x86_64 configurations in docker…
mathbunnyru Nov 20, 2025
1938101
build for aarch64-pytorch-cuda11 as well (for GH100 and simplified CI…
dictcp Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/docker-tag-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ jobs:
image: ${{ inputs.image }}
variant: ${{ inputs.variant }}
platform: aarch64
if: ${{ !contains(inputs.variant, 'cuda') }}
Copy link
Member

@mathbunnyru mathbunnyru Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You either have to make it work for pytorch-cuda11, or do not download it here, otherwise it will fail

Copy link
Author

@dictcp dictcp Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added pytorch-cuda11 to keep thing easier to read. (and ppl using GH100 can use this image 😀)

Copy link
Member

@mathbunnyru mathbunnyru Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dictcp it seems we can't build it, so you need to revert last commit and make an exception here


- name: Download x86_64 image tar and apply tags 🏷
uses: ./.github/actions/apply-single-tags
Expand Down
26 changes: 26 additions & 0 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,18 @@ jobs:
needs: x86_64-scipy
if: ${{ !contains(github.event.pull_request.title, '[FAST_BUILD]') }}

aarch64-tensorflow-cuda:
uses: ./.github/workflows/docker-build-test-upload.yml
with:
parent-image: scipy-notebook
image: tensorflow-notebook
variant: cuda
platform: aarch64
runs-on: ubuntu-24.04-arm
timeout-minutes: 25
needs: aarch64-scipy
if: ${{ !contains(github.event.pull_request.title, '[FAST_BUILD]') }}

x86_64-tensorflow-cuda:
uses: ./.github/workflows/docker-build-test-upload.yml
with:
Expand Down Expand Up @@ -248,6 +260,18 @@ jobs:
needs: x86_64-scipy
if: ${{ !contains(github.event.pull_request.title, '[FAST_BUILD]') }}

aarch64-pytorch-cuda12:
uses: ./.github/workflows/docker-build-test-upload.yml
with:
parent-image: scipy-notebook
image: pytorch-notebook
variant: cuda12
platform: aarch64
runs-on: ubuntu-24.04-arm
timeout-minutes: 25
needs: aarch64-scipy
if: ${{ !contains(github.event.pull_request.title, '[FAST_BUILD]') }}

x86_64-pytorch-cuda11:
uses: ./.github/workflows/docker-build-test-upload.yml
with:
Expand Down Expand Up @@ -392,7 +416,9 @@ jobs:
aarch64-r,
aarch64-julia,
aarch64-tensorflow,
aarch64-tensorflow-cuda,
aarch64-pytorch,
aarch64-pytorch-cuda12,
aarch64-datascience,
aarch64-pyspark,
aarch64-all-spark,
Expand Down
Loading