Skip to content

[FAST_BUILD] Merge manifests without pulling images#2377

Merged
mathbunnyru merged 9 commits intojupyter:mainfrom
mathbunnyru:merge_without_pull
Dec 7, 2025
Merged

[FAST_BUILD] Merge manifests without pulling images#2377
mathbunnyru merged 9 commits intojupyter:mainfrom
mathbunnyru:merge_without_pull

Conversation

@mathbunnyru
Copy link
Member

@mathbunnyru mathbunnyru commented Dec 7, 2025

Describe your changes

Pros:

  • works faster (as it pushes tag separately for 2 archs)
  • design is slightly better - we should as much as possible in parallel
  • doesn't use docker manifest, which is experimental
  • less likely to timeout / run out of space
  • The merge script only uses information from the registry and correctly handles some cases, where tag doesn't exist in the registry

Cons:

  • duplication due to reusable workflows
  • more workflows

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru mathbunnyru merged commit 9fd355b into jupyter:main Dec 7, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant