deprecate extracting dates in message headers#1015
Open
minrk wants to merge 3 commits intojupyter:mainfrom
Open
deprecate extracting dates in message headers#1015minrk wants to merge 3 commits intojupyter:mainfrom
minrk wants to merge 3 commits intojupyter:mainfrom
Conversation
adds Session.extract_header_dates config and JUPYTER_SESSION_EXTRACT_HEADER_DATES env default unchanged, but deprecated
minrk
force-pushed
the
deprecate-extract-dates
branch
from
0229711 to
bbc9559
Compare
Member
|
This seems worthy of polishing off after a rebase. |
Member
Author
|
The other option is to make the change and give an opt-out for backward compatibility. I expect the affected cases to be quite rare, but not none. |
Member
|
I just now saw your last commit. I shipped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds Session.extract_header_dates config and JUPYTER_SESSION_EXTRACT_HEADER_DATES env.
Proposal for #1014 because I'm not sure the best way to handle the deprecation.
Even if we don't deprecate the current behavior, the instance config here would allow ipyparallel to remove its monkeypatch.
default unchanged, but deprecated
closes #1014
closes #590