Skip to content

Use non-blocking zmq Poller #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2024
+8 −10
Merged

Use non-blocking zmq Poller #1023

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f73491
Use non-blocking zmq Poller
fcollonval May 14, 2024
41479de
Pin pytest<8.2.0
fcollonval May 14, 2024
a563aa6
Fix mypy
fcollonval May 14, 2024
733bd59
Apply review comment
fcollonval May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jupyter_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ async def _async_execute_interactive(
else:
timeout_ms = None

poller = zmq.Poller()
poller = zmq.asyncio.Poller()
iopub_socket = self.iopub_channel.socket
poller.register(iopub_socket, zmq.POLLIN)
if allow_stdin:
Expand All @@ -544,7 +544,7 @@ async def _async_execute_interactive(
if timeout is not None:
timeout = max(0, deadline - time.monotonic())
timeout_ms = int(1000 * timeout)
events = dict(poller.poll(timeout_ms))
events = dict(await poller.poll(timeout_ms))
if not events:
emsg = "Timeout waiting for output"
raise TimeoutError(emsg)
Expand Down