Convert str to bytes for comparing 'key'#1057
Draft
bsundaram1 wants to merge 3 commits intojupyter:mainfrom
Draft
Convert str to bytes for comparing 'key'#1057bsundaram1 wants to merge 3 commits intojupyter:mainfrom
bsundaram1 wants to merge 3 commits intojupyter:mainfrom
Conversation
Making sure that the key named 'key' is consistently bytes across the values returned by KernelManager and the provisioner.
for more information, see https://pre-commit.ci
Member
|
This makes sense in principle, but points to a general issue, that maybe the wrong data is being passed to this function and the fix belongs elsewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making sure that the key named 'key' is consistently bytes across the values returned by KernelManager and the provisioner.