Skip to content

Conversation

@minrk
Copy link
Member

@minrk minrk commented Jan 13, 2016

allows other code to take over fork-safety, as is planned in ipython/ipykernel#85

@Carreau
Copy link
Member

Carreau commented Jan 13, 2016

unfortunately need rebase.

@minrk minrk force-pushed the check-fork-optional branch from 9d9dbef to e6e4384 Compare January 15, 2016 10:42
@minrk
Copy link
Member Author

minrk commented Jan 15, 2016

rebased

@minrk
Copy link
Member Author

minrk commented Jan 19, 2016

Perhaps what makes more sense is a per-socket fork-safe signaling mechanism (e.g. getattr(socket, '_fork_safe', False)). Or we could assume objects that aren't zmq.Socket are fork-safe. I'm not sure what the best solution is.

@Carreau
Copy link
Member

Carreau commented Feb 22, 2016

Perhaps what makes more sense is a per-socket fork-safe signaling mechanism (e.g. getattr(socket, '_fork_safe', False)). Or we could assume objects that aren't zmq.Socket are fork-safe. I'm not sure what the best solution is.

Let's go with this one for now.

Carreau added a commit that referenced this pull request Feb 22, 2016
make fork-safety check optional
@Carreau Carreau merged commit d68f79d into jupyter:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants