-
Notifications
You must be signed in to change notification settings - Fork 304
Drop 3.9, Start testing on 3.14 and 3.14-free-threaded, get tests passing again #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 37 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
664c75a
start testing on 3.14 and 3.14-free-threaded
Carreau 80f729b
mark xfail on free-threaded
Carreau 7a565ac
remove mambaforge variant
Carreau 92c22d4
remove papermill (unmaintained)
Carreau d2b430c
Also drop 3.9 and cleanup conditional code
Carreau 7d374f9
fix pre-commit after bump to 3.10
Carreau 51ea989
bump min in github action
Carreau 93064d8
update pre-commit
Carreau 5d6b47f
fix all pre-commit issues
Carreau c0e7704
skip failint tests on 3.14
Carreau 6301e78
remove all ignored types comments
Carreau 35e77ba
fix mypy lints
Carreau 2f42590
fix some min
Carreau ffdb3b8
try to skip min test
Carreau 8812c1e
bump min as min_versin test are failing
Carreau 70ea317
skip tcp test
Carreau 1c9139a
bump pytest jupyter
Carreau e99a846
memoryview.contiguous is safe
minrk e4665ef
need tornado 6.4.1 for
minrk fcc627b
don't run tests twice on failure
minrk 8843b77
try to do better at closing event loops
minrk 7f7c69e
only close loop if there is one to close
minrk 043876b
debug: show tracemalloc for unclosed resources
minrk 2eefaa5
simplify selecting nowarn/nocover in tests
minrk e9e4493
show minimum versions env
minrk 9533d15
stop skipping test_input_request
minrk fe77c35
cleanup more unclosed sockets
minrk 40412b0
try to make sure hatch uses our python
minrk b28b7f4
increase test timeout
minrk b5dc28b
increase some test timeouts
minrk 79c616b
back to 100s
minrk 33d6483
client: destroy created context in stop_channels
minrk ff0e5e7
increase per-test timeout in test_kernelmanager
minrk 7040d28
increase timeouts in test_multikernelmanager, test_client
minrk f86d0af
set linger when destroying client
minrk d4fbcdb
try to cleanup a lot of leftover contexts
minrk ccb9642
restore tests_check to unblock branch protection
minrk 8986ce3
revert default nowarn for debug
minrk 6b6de4c
Apply suggestion from @Carreau
minrk 31453ce
set linger in destroy so it exits eventually
minrk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| """The version information for jupyter client.""" | ||
|
|
||
| import re | ||
| from typing import Union | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want this to be permanent ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is not a change, it simplifies the 3 different test invocations below by setting the options before using the same pytest invocation.