Skip to content

Test downstream projects #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blink1073 merged 1 commit into from
Jul 30, 2021
Merged

Test downstream projects #644

blink1073 merged 1 commit into from
Jul 30, 2021

Conversation

@davidbrochart
Copy link
Member

@davidbrochart davidbrochart commented Apr 13, 2021

Fixes #639

@davidbrochart davidbrochart force-pushed the test_downstream branch 6 times, most recently from 1762787 to a79fa9b Compare April 13, 2021 07:53
@davidbrochart
Copy link
Member Author

davidbrochart commented Apr 13, 2021 •
edited
Loading

The tests fail in downstream projects because ipykernel master breaks nbclient (see ipython/ipykernel#635) and we need ipykernel master because of this change: ipython/ipykernel#634.

@blink1073 blink1073 added this to the 7.0 milestone Jul 9, 2021
@blink1073
Copy link
Contributor

blink1073 commented Jul 30, 2021

Kicking CI

@blink1073 blink1073 closed this Jul 30, 2021
@blink1073 blink1073 reopened this Jul 30, 2021
@blink1073
Copy link
Contributor

blink1073 commented Jul 30, 2021

Looks like still have some failures. @davidbrochart are you able to pick this back up for the 7.0 release?

@davidbrochart
Copy link
Member Author

davidbrochart commented Jul 30, 2021

Sure, I'm going to look into it.

@davidbrochart davidbrochart force-pushed the test_downstream branch 2 times, most recently from 9c3b9bb to 3ebb920 Compare July 30, 2021 14:06
@davidbrochart
Copy link
Member Author

davidbrochart commented Jul 30, 2021

I commented out the tests for the following packages:

We successfully pass the tests for:

  • ipykernel==6.0.3
  • nbclient==0.5.3
  • nbconvert==6.1.0

blink1073
blink1073 approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 3544ead into jupyter:master Jul 30, 2021
@davidbrochart davidbrochart deleted the test_downstream branch July 30, 2021 14:34
@davidbrochart
Copy link
Member Author

davidbrochart commented Jul 30, 2021

I just tested jupyter_server master locally with jupyter_client master and all tests pass except for one related with nbconvert, so I thinks we are fine on the jupyter_server side.
I opened spyder-ide/qtconsole#494 and this should make qtconsole ready for jupyter_client 7.0.

@blink1073 blink1073 mentioned this pull request Aug 16, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blink1073 blink1073 blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

CI workflow to test downstream projects

2 participants

@davidbrochart @blink1073