-
Notifications
You must be signed in to change notification settings - Fork 188
require python 3.10, start to test on 3.14 and 3.14-free-threaded #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@minrk I see you recently removed and readded Python 3.8, would you be or to drop 3.8, and bump version number of 6.0 ? |
And I don't know what to do with the fialures, |
That was to get a security fix out without changing supported Python versions, fine to drop 3.8 and 3.9 now. |
Am I crazy? Mypy complains about (simplified):
But if I put an else, ruff complains for unnecessary else... |
Blarg, yeah, mypy's obviously wrong. I don't have a lot of patience for incorrect type checkers, so liberally ignoring their failures is okay with me. For ruff, I think it's because there's a
would resolve that, I think |
For the event loop policy, we could consider just removing it. pyzmq now works with proactor if tornado is available (via an additional thread), so if we require tornado 6.1, all should be okay (if less efficient than selector). We could also just ignore the deprecation warning. The code will still work (i.e. it will do nothing) after policies are removed, because they are protected by a check for an ImportError. I'm still incredibly frustrated that asyncio folks decided proactor was ready to be the default when it still lacks basic functionality of all other loops that needs to be worked around with threads. |
Rhaa mypy bug seem to be known. |
my inclination: suppress the deprecation warning for now, then we can propose a new way to do it without policies (I think an |
I think I'll be in favor of ignoring the warnings only python 3.14, and revisit for 3.15 |
46194d6
to
50d705d
Compare
This starts testing on 3.14 and and 3.14t as 3.14 introduce some eventloop policy deprecation we are not ready to deal with, we ignore warnings only on Python 3.14 Some tornado tests are failing on all windows platform, we skip those.
This include updating some repo, renaming some hooks, and run them to fix the corresponding files.
All passing, and please don't squash I properly cleaned-up each commit. |
Current version is 5.8.1, once this is merged, I suggest we bump version, and release soon. I'll suggest 2 new possible version numbers in two separate comments. Please upvote your peference. |
5.9, nothing specific but did drop 3.10 (and 3.9) and there was no release since 3.9 drops. |
6.0, this will let us do some cleanups in particular this deprecation warning:
EDIT: version published Nov 9 2022 |
We can also do 5.9, and do 6.0 in a month or so with all the cleanup we want. |
I think we can do 5.9 with these changes, I don't have a problem with dropping Python versions on minor releases, the tooling handles that well enough. I haven't pulled the trigger on completing the platformdirs change because I think it's not complete enough - #309 I don't think we should start the deprecation clock until we have had migration in place for quite some time, which we still don't. At this point, I agree with @ivanov that we should remove the deprecation warning and stop telling people the default is going to change. |
#447 removes the deprecation warning |
Thanks ! |
draft release: https://github.com/jupyter/jupyter_core/releases/tag/untagged-9833f440530aecf4ad1b ready to go? |
with warnings.catch_warnings(): | ||
warnings.filterwarnings( | ||
"ignore", | ||
DeprecationWarning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeprecationWarning, | |
category=DeprecationWarning, |
This is causing TypeError
in downstream package jupyterlab_server
when testing on Python 3.14 on Windows.
CC: @Carreau
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #449
5.9 is already out. |
No description provided.