Skip to content

Conversation

@RRosio
Copy link
Collaborator

@RRosio RRosio commented May 11, 2022

bower-lite copies dependencies into components folder. this is applying the changes made by @minrk in https://github.com/jupyter/notebook/pull/6213/files

…t to copy them into components folder. this is applying the changes made by @minrk in  https://github.com/jupyter/notebook/pull/6213/files
@RRosio RRosio closed this Aug 5, 2022
@jtpio
Copy link
Member

jtpio commented Jul 26, 2023

@RRosio curious if this ended up in another PR? The main branch still shows a bower.json file: https://github.com/jupyter/nbclassic/blob/main/bower.json

For more context jupyter/notebook#6213 is still open on the Notebook repo and I was wondering if we could close it there, since such change would have to be implemented in nbclassic anyway if still relevant?

@RRosio
Copy link
Collaborator Author

RRosio commented Jul 31, 2023

@jtpio apologies for the delay in my reply! I haven't made another PR for this in NbClassic, but I think it would still be worth having an issue open for this. I was thinking I could open another issue here in the NbClassic repo and we could close the Notebook issue as you suggest?

@jtpio
Copy link
Member

jtpio commented Jul 31, 2023

I was thinking I could open another issue here in the NbClassic repo and we could close the Notebook issue as you suggest?

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants