Skip to content

Close new event loops in just_run helper #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Close new event loops in just_run helper #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a12ea9
Close new event loops in just_run helper
takluyver Sep 13, 2021
8b6ea2d
Use temporary event loop when one is not already running in just_run
takluyver Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions nbclient/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,21 @@ def just_run(coro: Awaitable) -> Any:
# original from vaex/asyncio.py
loop = asyncio._get_running_loop()
if loop is None:
had_running_loop = False
# Create a temporary event loop
loop = asyncio.new_event_loop()
try:
loop = asyncio.get_event_loop()
except RuntimeError:
# we can still get 'There is no current event loop in ...'
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
return loop.run_until_complete(coro)
finally:
loop.close()

else:
had_running_loop = True
if had_running_loop:
# if there is a running loop, we patch using nest_asyncio
# to have reentrant event loops
check_ipython()
import nest_asyncio
nest_asyncio.apply()
check_patch_tornado()
return loop.run_until_complete(coro)
return loop.run_until_complete(coro)


def run_sync(coro: Callable) -> Callable:
Expand Down