Make sure kernel is cleaned up in case an error occurred while starting kernel client #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
davidbrochart
approved these changes
May 31, 2022
There was a problem hiding this comment.
Thanks a lot @CiprianAnton!
Let's just pin traitlets<5.2.0 for now, until ipython/traitlets#736 is fixed.
cc @blink1073
davidbrochart
force-pushed
the
users/canton/ensure-cleanup-in-case-of-kc-errors
branch
from
52d9edc to
95b26f0
Compare
davidbrochart
force-pushed
the
users/canton/ensure-cleanup-in-case-of-kc-errors
branch
from
f3dd8ff to
f9b48f1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an error happens in
start_channels(), the kernel is never cleaned up, leading to leaks. For e.g., inGatewayKernelClientthere is a chance we getConnectionError.Another place to ensure cleanup is in
setup_kernel, however, sinceasync_start_new_kernel_clientalready performs cleanup in case of timeout, I think it's a better fit here.Added test to cover this. All tests passed locally.