Skip to content

Commit 0af6834

Browse files
authored
Revert "Pin click<8.3 (#7729)" (#7733)
This reverts commit c0d3e8b.
1 parent c0d3e8b commit 0af6834

File tree

10 files changed

+3
-55
lines changed

10 files changed

+3
-55
lines changed

.github/actions/build-dist/action.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
name: 'Build Jupyter Notebook'
2-
32
description: 'Build Jupyter Notebook from source'
4-
53
runs:
64
using: 'composite'
75
steps:
@@ -11,7 +9,7 @@ runs:
119
- name: Install dependencies
1210
shell: bash
1311
run: |
14-
python -m pip install hatch "click<8.3.0"
12+
python -m pip install hatch
1513
1614
- name: Build pypi distributions
1715
shell: bash

.github/workflows/build.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ jobs:
4646
- name: Base Setup
4747
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
4848

49-
- name: Pin click to avoid 8.3.0 issues
50-
run: pipx inject --force hatch "click<8.3.0"
51-
5249
- name: Test the package
5350
run: hatch run cov:test
5451

@@ -82,8 +79,6 @@ jobs:
8279
steps:
8380
- uses: actions/checkout@v5
8481
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
85-
- name: Pin click to avoid 8.3.0 issues
86-
run: pipx inject --force hatch "click<8.3.0"
8782
- run: |
8883
sudo apt-get update
8984
sudo apt install enchant-2 # for spelling
@@ -102,8 +97,6 @@ jobs:
10297
with:
10398
dependency_type: minimum
10499
python_version: '3.10'
105-
- name: Pin click to avoid 8.3.0 issues
106-
run: pipx inject --force hatch "click<8.3.0"
107100
- name: Run the unit tests
108101
run: |
109102
hatch run test:nowarn || hatch run test:nowarn --lf
@@ -117,8 +110,6 @@ jobs:
117110
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
118111
with:
119112
dependency_type: pre
120-
- name: Pin click to avoid 8.3.0 issues
121-
run: pipx inject --force hatch "click<8.3.0"
122113
- name: Run the tests
123114
run: |
124115
hatch run test:nowarn || hatch run test:nowarn --lf
@@ -181,8 +172,6 @@ jobs:
181172
steps:
182173
- uses: actions/checkout@v5
183174
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
184-
- name: Pin click to avoid 8.3.0 issues
185-
run: pipx inject --force hatch "click<8.3.0"
186175
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
187176
with:
188177
ignore_links: 'https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main https://nbviewer.jupyter.org https://stackoverflow.com https://github.com/[^/]+/?$'
@@ -194,8 +183,6 @@ jobs:
194183
steps:
195184
- uses: actions/checkout@v5
196185
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
197-
- name: Pin click to avoid 8.3.0 issues
198-
run: pipx inject --force hatch "click<8.3.0"
199186
- name: Run Linters
200187
run: |
201188
hatch run typing:test

.github/workflows/buildutils.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ concurrency:
1616
permissions:
1717
contents: read
1818

19-
2019
jobs:
2120
versioning:
2221
runs-on: ubuntu-latest
@@ -28,12 +27,9 @@ jobs:
2827
- name: Base Setup
2928
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
3029

31-
- name: Pin click to avoid 8.3.0 issues
32-
run: pipx inject --force hatch "click<8.3.0"
33-
3430
- name: Install dependencies
3531
run: |
36-
python -m pip install -U "jupyterlab>=4.5.0a0,<4.6"
32+
python -m pip install -U "jupyterlab>=4.5.0a0,<4.6" hatch
3733
jlpm
3834
jlpm run build
3935

.github/workflows/check-release.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,15 @@ concurrency:
1111
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
1212
cancel-in-progress: true
1313

14-
1514
jobs:
1615
check_release:
1716
runs-on: ubuntu-latest
1817
timeout-minutes: 30
1918
steps:
2019
- name: Checkout
2120
uses: actions/checkout@v5
22-
2321
- name: Base Setup
2422
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
25-
26-
- name: Pin click to avoid 8.3.0 issues
27-
run: pipx inject --force hatch "click<8.3.0"
28-
2923
- name: Check Release
3024
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
3125
with:

.github/workflows/playwright-update.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ on:
77
permissions:
88
contents: read
99

10-
1110
jobs:
1211
update-snapshots:
1312
if: >
@@ -84,9 +83,6 @@ jobs:
8483
- name: Base Setup
8584
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
8685

87-
- name: Pin click to avoid 8.3.0 issues
88-
run: pipx inject --force hatch "click<8.3.0"
89-
9086
- name: Build
9187
uses: ./.github/actions/build-dist
9288

.github/workflows/prep-release.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ on:
2323
description: "Use PRs with activity since the last stable git tag"
2424
required: false
2525
type: boolean
26-
27-
2826
jobs:
2927
prep_release:
3028
runs-on: ubuntu-latest
@@ -33,9 +31,6 @@ jobs:
3331
steps:
3432
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
3533

36-
- name: Pin click to avoid 8.3.0 issues
37-
run: pipx inject --force hatch "click<8.3.0"
38-
3934
- name: Prep Release
4035
id: prep-release
4136
uses: jupyter-server/jupyter_releaser/.github/actions/prep-release@v2

.github/workflows/publish-changelog.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,13 @@ on:
99
description: "The branch to target"
1010
required: false
1111

12-
1312
jobs:
1413
publish_changelog:
1514
runs-on: ubuntu-latest
1615
environment: release
1716
steps:
1817
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
1918

20-
- name: Pin click to avoid 8.3.0 issues
21-
run: pipx inject --force hatch "click<8.3.0"
22-
2319
- uses: actions/create-github-app-token@v2
2420
id: app-token
2521
with:

.github/workflows/publish-release.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ on:
1212
description: "Comma separated list of steps to skip"
1313
required: false
1414

15-
1615
jobs:
1716
publish_release:
1817
runs-on: ubuntu-latest
@@ -22,12 +21,6 @@ jobs:
2221
steps:
2322
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
2423

25-
- name: Install jupyter-releaser
26-
run: pipx install jupyter-releaser
27-
28-
- name: Pin click to avoid 8.3.0 issues
29-
run: pipx inject --force hatch "click<8.3.0"
30-
3124
- uses: actions/create-github-app-token@v2
3225
id: app-token
3326
with:

.github/workflows/ui-tests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ concurrency:
1212
permissions:
1313
contents: read
1414

15-
1615
jobs:
1716
build:
1817
name: Build
@@ -40,9 +39,6 @@ jobs:
4039
- name: Base Setup
4140
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
4241

43-
- name: Pin click to avoid 8.3.0 issues
44-
run: pipx inject --force hatch "click<8.3.0"
45-
4642
- uses: actions/download-artifact@v5
4743
with:
4844
name: notebook-dist-${{ github.run_number }}

pyproject.toml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
requires = [
33
"hatchling>=1.11",
44
"jupyterlab>=4.5.0a3,<4.6",
5-
"click<8.3.0",
65
]
76
build-backend = "hatchling.build"
87

@@ -64,7 +63,6 @@ test = [
6463
"jupyter_server[test]>=2.4.0,<3",
6564
"jupyterlab_server[test]>=2.27.1,<3",
6665
"importlib-resources>=5.0;python_version<\"3.10\"",
67-
"click<8.3.0",
6866
]
6967
docs = [
7068
"myst_parser",
@@ -76,8 +74,7 @@ docs = [
7674
]
7775
dev = [
7876
"pre-commit",
79-
"hatch",
80-
"click<8.3.0",
77+
"hatch"
8178
]
8279

8380
[tool.hatch.version]

0 commit comments

Comments
 (0)