Skip to content

Commit 217c96e

Browse files
committed
fix test berendjan
1 parent 43df5af commit 217c96e

File tree

1 file changed

+10
-33
lines changed

1 file changed

+10
-33
lines changed

notebook/static/notebook/js/outputarea.js

Lines changed: 10 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -838,56 +838,33 @@ define([
838838
}
839839
};
840840

841-
var append_png = function (png, md, element, handle_inserted) {
842-
var type = MIME_PNG;
843-
var toinsert = this.create_output_subarea(md, "output_png", type);
841+
OutputArea.prototype.append_img = function (src_type, md, element, handle_inserted, MIME, type_string) {
842+
var type = MIME;
843+
var toinsert = this.create_output_subarea(md, 'output_' + type_string, type);
844844
var img = $("<img/>");
845845
if (handle_inserted !== undefined) {
846846
img.on('load', function(){
847847
handle_inserted(img);
848848
});
849849
}
850-
img[0].src = 'data:image/png;base64,'+ png;
850+
img[0].src = 'data:image/' + type_string + ';base64,'+ src_type;
851851
set_width_height(img, md, type);
852852
dblclick_to_reset_size(img);
853853
toinsert.append(img);
854854
element.append(toinsert);
855855
return toinsert;
856856
};
857-
857+
858+
var append_png = function (png, md, element, handle_inserted) {
859+
return this.append_img(png, md, element, handle_inserted, MIME_PNG, 'png');
860+
};
858861

859862
var append_jpeg = function (jpeg, md, element, handle_inserted) {
860-
var type = MIME_JPEG;
861-
var toinsert = this.create_output_subarea(md, "output_jpeg", type);
862-
var img = $("<img/>");
863-
if (handle_inserted !== undefined) {
864-
img.on('load', function(){
865-
handle_inserted(img);
866-
});
867-
}
868-
img[0].src = 'data:image/jpeg;base64,'+ jpeg;
869-
set_width_height(img, md, type);
870-
dblclick_to_reset_size(img);
871-
toinsert.append(img);
872-
element.append(toinsert);
873-
return toinsert;
863+
return this.append_img(jpeg, md, element, handle_inserted, MIME_JPEG, 'jpeg');
874864
};
875865

876866
var append_gif = function (gif, md, element, handle_inserted) {
877-
var type = MIME_GIF;
878-
var toinsert = this.create_output_subarea(md, "output_gif", type);
879-
var img = $("<img/>");
880-
if (handle_inserted !== undefined) {
881-
img.on('load', function(){
882-
handle_inserted(img);
883-
});
884-
}
885-
img[0].src = 'data:image/gif;base64,'+ gif;
886-
set_width_height(img, md, type);
887-
dblclick_to_reset_size(img);
888-
toinsert.append(img);
889-
element.append(toinsert);
890-
return toinsert;
867+
return this.append_img(gif, md, element, handle_inserted, MIME_GIF, 'gif');
891868
};
892869

893870

0 commit comments

Comments
 (0)