Skip to content

Conversation

@mgeier
Copy link
Contributor

@mgeier mgeier commented Feb 17, 2019

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 added this to the 6.1 milestone Jun 3, 2020
@blink1073 blink1073 merged commit 5aba3b8 into jupyter:master Jun 3, 2020
@mgeier
Copy link
Contributor Author

mgeier commented Jun 10, 2020

Thanks for merging, but jupyterlab/jupyterlab#5997 has been closed without merging, as it turned out to be not necessary (see discussion there).

I guess it isn't a big deal, but in the interest of feature parity, I think it would be actually better to revert this.

@mgeier mgeier deleted the gdef branch June 10, 2020 12:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants