Skip to content

Toolbar buttons tooltip: show help instead of label #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2020
+2 −1
Merged

Toolbar buttons tooltip: show help instead of label #5107

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f86ef
Toolbar buttons tooltip: show help instead of label
manics Dec 7, 2019
5d47947
Toolbar buttons tooltip: fallback to label as tooltip, set aria-label
manics May 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notebook/static/notebook/js/toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ define(['jquery','base/js/i18n'], function($, i18n) {
}
var button = $('<button/>')
.addClass('btn btn-default')
.attr("title", el.label||i18n.msg._(action.help))
.attr("title", i18n.msg._(action.help))
.append(
$("<i/>").addClass(el.icon||(action||{icon:'fa-exclamation-triangle'}).icon).addClass('fa')
);
Expand Down