Refactor code duplication of markdown renderers #5488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Thanks, @toonijn! I really appreciate your work here. I'll review this as soon as possible. |
Member
detect deletion of files
toonijn
force-pushed
the
refactor-markdown
branch
from
6b89c38 to
238828e
Compare
kevin-bates
approved these changes
Oct 7, 2020
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Sorry for the delay - these changes look good. Thank you!
Member
|
I missed this in initial review, but looks like the following file was moved: This causes issues for extensions, i.e. Jupyter-contrib/jupyter_nbextensions_configurator#125 |
Contributor
Author
|
I'm sorry, I didn't realise this impacted the plugins. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In textcell.js and outputarea.js markdown is being rendered. This PR brings the code together in 1 function.