Fix: split_cell doesn't always split cell #6017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Mar 24, 2021
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Thanks @gamestrRUS - this seems to work as you advertise - thank you.
Since I don't feel qualified to comment on the code changes - although they "read" fine to me - I'd like someone from the front-end to check the changes before we merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve issues.
Summary issues: not work split cell at cursor(s) hotkey (Ctrl-Shift--) after this PR
Also add duplicate cell if full cell is selected.