get bower dependencies from npm #6213
Conversation
minrk
force-pushed
the
bower-lite
branch
4 times, most recently
from
3fe19a9 to
d03d798
Compare
a couple of packages have different layouts (jquery-ui, react, xterm), but little is changed a 'bower-lite' script copies dependencies from node_modules to `static/components` to match previous installation location
|
Thanks, @minrk! We'll review this in Wednesday's notebook meeting. 😎 |
|
I think there's a real test failure, presumably related to a url somewhere or other that needs updating, but I haven't found it. Things seem to work when I test locally. |
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Although I'm not qualified to review these changes, notebook builds and appears to run fine.
I think we should move forward with this so we can address #6254, but would like someone with frontend experience to review as well.
@minrk - could you please point out the test failure (tests aren't very stable at the moment and I'm not sure what might be real or fake)? Perhaps someone could then take a look if there's a starting point. |
|
Closing this PR as an issue has been opened for this work on NbClassic, where this could be addressed. |
5 participants
Avoids dependency on deprecated bower package manager.
This is the same strategy adopted some time ago by JupyterHub, which also used Bower. Rather than making significant changes to how everything is built, which caused problems during the webpack, this only changes how the dependencies are downloaded. A
bower-litescript copies dependencies declared inpackage.jsonfrom node_modules tonotebook/static/componentsto match the previous installation location.Most packages are identical, but a couple of packages have slightly different layouts (jquery-ui, react, xterm). It's unclear if these relative URLs should be considered public APIs, in which case we can make do more detailed renames to match everything exactly.
Related to #6210