-
Notifications
You must be signed in to change notification settings - Fork 24
Fix orthographic camera near and far parameters #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arjxn-py
wants to merge
11
commits into
jupytercad:main
Choose a base branch
from
arjxn-py:orthographic-zoom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
812930a
Fix orthographic camera zoom
arjxn-py 8b3c0aa
remove extra code
arjxn-py c9a9db3
lint
arjxn-py 21e4c09
Start with camera from settings and update camera params in updateref…
arjxn-py dd6494a
lint
arjxn-py 3f2cd50
Update packages/base/src/3dview/mainview.tsx
arjxn-py 1bc2a74
Update packages/base/src/3dview/mainview.tsx
arjxn-py 74341bb
Update camera position as well based upon reflength
arjxn-py e8a2b42
Push it to just try
arjxn-py c2f08f8
Apply suggestions from code review
arjxn-py 5f39ecd
Apply suggestions from code review
arjxn-py File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.