Skip to content

Use Traitlets for passing parameters to Build classes #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 15, 2022
Merged

Use Traitlets for passing parameters to Build classes #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d04e88e
Replace `Build` class with new traitlets classes
manics Jul 28, 2022
6e65ec4
`Build.cleanup_builds` is now a standalone traitlets-based class
manics Jul 28, 2022
5c68741
Use traitlets BuildExecutor in app
manics Jul 30, 2022
0726b2e
Pass event loop instead of using current()
manics Jul 30, 2022
2a10ed1
CI: don't rely on current ioloop
manics Aug 1, 2022
57a1d8d
ci: test.yml add time limit for jobs
manics Aug 1, 2022
9e20437
Mock Build tests: need to use correct types and set loop
manics Aug 1, 2022
78fb0aa
KubernetesBuildExecutor: ensure traitlets have defaults
manics Aug 2, 2022
bbfb96b
BuildExecutor: appendix git_credentials push_secret q types
manics Aug 8, 2022
99a8ac8
Remove MagicMock from test_build Build params
manics Aug 8, 2022
8b0dafa
Don't pass ioloop around app, only pass to BuildExecutor
manics Aug 8, 2022
eeee549
conftest: io_loop fixture is async
manics Aug 8, 2022
aea5b3d
Setup main_loop inside BuildExecutor
manics Aug 8, 2022
60429f7
Setup main_loop inside BuildExecutor.__init__
manics Aug 8, 2022
e666855
git_credentials must be a string, don't cast
manics Aug 12, 2022
eea8e6e
BuildExecutor.appendix set by traitlets, not passed from BinderHub.ap…
manics Aug 12, 2022
dd2d26c
builder.py deprecation: xref Build class
manics Aug 14, 2022
b49edf6
BuildExecutor.stop: docstring clasrification
manics Aug 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
# jobs or have "template" jobs, so we use `if` conditions on steps
tests:
runs-on: ubuntu-20.04
timeout-minutes: 10
strategy:
# keep running so we can see if tests with other k3s/k8s/helm versions pass
fail-fast: false
Expand Down Expand Up @@ -278,6 +279,7 @@ jobs:

test-local:
runs-on: ubuntu-20.04
timeout-minutes: 5
steps:
- uses: actions/checkout@v3

Expand Down
6 changes: 4 additions & 2 deletions binderhub/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
from traitlets.config import Application

from .base import AboutHandler, Custom404, VersionHandler
from .build import Build
from .build import Build, BuildExecutor
from .builder import BuildHandler
from .config import ConfigHandler
from .events import EventLog
Expand Down Expand Up @@ -270,10 +270,11 @@ def _valid_badge_base_url(self, proposal):

build_class = Type(
Build,
klass=BuildExecutor,
help="""
The class used to build repo2docker images.

Must inherit from binderhub.build.Build
Must inherit from binderhub.build.BuildExecutor
""",
config=True,
)
Expand Down Expand Up @@ -818,6 +819,7 @@ def initialize(self, *args, **kwargs):
"build_class": self.build_class,
"registry": registry,
"traitlets_config": self.config,
"traitlets_parent": self,
"google_analytics_code": self.google_analytics_code,
"google_analytics_domain": self.google_analytics_domain,
"about_message": self.about_message,
Expand Down
Loading